Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent perfcounters from stopping MonitoringService #1417

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

niklasi
Copy link

@niklasi niklasi commented Sep 9, 2017

On Windows you can get problems with corrupt peformance counters and
this can prevent the MonitoringService from saving stats.
Some calls to the perfcounters is wrapped in a try-catch with a retry,
but not all of them.

Fix: Handle the calls to the gc-stats perfcounters the same way as the
rest of the perfcounters.

On Windows you can get problems with corrupt peformance counters and
this can prevent the MonitoringService from saving stats.
Some calls to the perfcounters is wrapped in a try-catch with a retry,
but not all of them.

Fix: Handle the calls to the gc-stats perfcounters the same way as the
rest of the perfcounters.
@pgermishuys
Copy link
Contributor

Looks good to me, waiting for the tests to pass.

@pgermishuys pgermishuys merged commit 4a2a128 into EventStore:release-v4.0.3 Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants