Non Promotable Clone #1751
Closed
Non Promotable Clone #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
hello @riccardone can you please rebase again? (there was an issue with fork PRs on CI) |
riccardone
changed the title
|
This is now in progress |
|
@riccardone there are some conflicts to resolve here too (I guess related to argument passing). Can you please rebase to |
|
Will this make the cut for 5.0? It is worth noting that the docs suggest this is already a thing... |
|
Hi @jcelgin - 5.0.0 is already out, so no - but it should make 5.1.0 shortly, once it’s had some more thorough testing. |
…se, the node does not partecipate in the election process as a candidate
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new IsPromotable config setting (default true)
When it is set to false, the node does not partecipate in the election process as a candidate and it does not allow the cluster to stay up if there are not enough (other) nodes to form a quorum
Added a new test for the ElectionService changes (more tests can be added... as usual)
To test this PR, run a cluster of 3 nodes. This cluster could be the current stable version.
Once that the cluster is up and running, run a node using this PR code and IsPromotable set to false.
Remember to keep the clustersize 3 and use the same gossip port of the other nodes in order to join the existing cluster.
You can verify that the node is recognize as NonPromotableClone and it does not partecipate as a candidate in the Election Process when you shut down the other nodes for testing.
Closes #263
Closes EventStore/EventStore.CommercialHA#36