Filter out unresolved events when checking for deleted partitions #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
added
subsystem/projections
thefringeninja
approved these changes
Jul 7, 2020
shaan1337
approved these changes
Jul 8, 2020
hayley-jean
pushed a commit
that referenced
this pull request
Jul 8, 2020
Filter out unresolved events when checking for deleted partitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Don't treat unresolved links as deleted linkTo events when checking for deleted partitions in projections.
Fixes #2532
If multiple deleted events for the same stream are written quickly, it's possible for the projection to process a deleted link event that couldn't be resolved. This can result in the projection processing the event twice, once as a committed event and once as a partition deleted event. See the issue for details on how/why this happens.
This PR changes the check for whether to publish an
EventReaderPartitionDeletedmessage to also check if the link is resolved.Because the partition deleted messages don't get emitted this change should be backwards compatible.