Improve stream existence bloom filter V2 initialization #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timothycoleman
commented
Oct 20, 2021
timothycoleman
commented
- Try (repeatedly) to get iterators on each table we will consume so that they can't be deleted (due to merges) while we are using them
- Derive the checkpoint from the max position we found in the index. Previously we were using tableindex.CommitCheckpoint which can be considerably behind (will be -1 if we just rebuilt the main index too)
- Try (repeatedly) to get iterators on each table we will consume so that they can't be deleted (due to merges) while we are using them - Derive the checkpoint from the max position we found in the index. Previously we were using tableindex.CommitCheckpoint which can be considerably behind (will be -1 if we just rebuilt the main index too)
timothycoleman
force-pushed
the
merge-on-bloom-filter-initialization
branch
from
e24ada4
to
383a69b
Compare
timothycoleman
added
the
cherry-pick:release/oss-v21.10
shaan1337
approved these changes
Oct 22, 2021
pvanbuijtene
approved these changes
Oct 22, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
@pvanbuijtene 👉 Created pull request targeting release/oss-v21.10: #3240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.