Ensure persistent subscriptions messages don't continue on the main queue #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Persistent Subscription IODispatcher to publish completed messages onto the PSub queue. This prevents continuations which could take a long time to process from happening on the main queue.
timothycoleman
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
great 👍
There is only one other IODispatcher that runs its continuations on the main queue, but it seems not to actually be used at all. For completeness I have removed it here #3709
pvanbuijtene
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Publish messages from the persistent subscriptions IODispatcher to the Persistent Subscriptions queue rather than the main queue
This prevents continuations which could take a long time to process from happening on the main queue.
Fixes https://github.com/EventStore/home/issues/885