Create and use a separate iodispatcher for scavenge log #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayley-jean
force-pushed
the
hayley-jean/fix-scavenging-dispatcher
branch
from
9dc3278
to
3bd2980
Compare
dhingrak
approved these changes
Feb 24, 2023
timothycoleman
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Looks good 👍
For posterity, the risk of the IO Dispatcher publishing on to the mainqueue is that the registered callbacks will be called on the main bus which is dangerous if they aren't guaranteed to be quick. I've checked that the callbacks on this iodispatcher are quick and they all look fine except for TFChunkScavengerLogManager::GatherIncompleteScavenges which is potentially longer but only happens once on startup so I think this is fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Use a separate IODispatcher for scavenge log
This fixes a bug introduced by #3702, which changed the IODispatcher used by persistent subscriptions to subscribe and publish to the psub-specific queues and buses.
However, the scavenge log was using the same IODispatcher, so the messages for scavenging were being sent to the wrong queue.