Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and use a separate iodispatcher for scavenge log #3741

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Create and use a separate iodispatcher for scavenge log #3741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions src/EventStore.Core/ClusterVNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,16 +1190,16 @@ public class ClusterVNode<TStreamId> :
var perSubscrBus = new InMemoryBus("PersistentSubscriptionsBus", true, TimeSpan.FromMilliseconds(50));
var perSubscrQueue = new QueuedHandlerThreadPool(perSubscrBus, "PersistentSubscriptions", _queueStatsManager,
trackers.QueueTrackers, false);
var ioDispatcher = new IODispatcher(_mainQueue, new PublishEnvelope(perSubscrQueue));
perSubscrBus.Subscribe<ClientMessage.ReadStreamEventsBackwardCompleted>(ioDispatcher.BackwardReader);
perSubscrBus.Subscribe<ClientMessage.NotHandled>(ioDispatcher.BackwardReader);
perSubscrBus.Subscribe<ClientMessage.WriteEventsCompleted>(ioDispatcher.Writer);
perSubscrBus.Subscribe<ClientMessage.ReadStreamEventsForwardCompleted>(ioDispatcher.ForwardReader);
perSubscrBus.Subscribe<ClientMessage.ReadAllEventsForwardCompleted>(ioDispatcher.AllForwardReader);
perSubscrBus.Subscribe<ClientMessage.FilteredReadAllEventsForwardCompleted>(ioDispatcher.AllForwardFilteredReader);
perSubscrBus.Subscribe<ClientMessage.DeleteStreamCompleted>(ioDispatcher.StreamDeleter);
perSubscrBus.Subscribe<IODispatcherDelayedMessage>(ioDispatcher);
perSubscrBus.Subscribe<ClientMessage.NotHandled>(ioDispatcher);
var psubDispatcher = new IODispatcher(_mainQueue, new PublishEnvelope(perSubscrQueue));
perSubscrBus.Subscribe<ClientMessage.ReadStreamEventsBackwardCompleted>(psubDispatcher.BackwardReader);
perSubscrBus.Subscribe<ClientMessage.NotHandled>(psubDispatcher.BackwardReader);
perSubscrBus.Subscribe<ClientMessage.WriteEventsCompleted>(psubDispatcher.Writer);
perSubscrBus.Subscribe<ClientMessage.ReadStreamEventsForwardCompleted>(psubDispatcher.ForwardReader);
perSubscrBus.Subscribe<ClientMessage.ReadAllEventsForwardCompleted>(psubDispatcher.AllForwardReader);
perSubscrBus.Subscribe<ClientMessage.FilteredReadAllEventsForwardCompleted>(psubDispatcher.AllForwardFilteredReader);
perSubscrBus.Subscribe<ClientMessage.DeleteStreamCompleted>(psubDispatcher.StreamDeleter);
perSubscrBus.Subscribe<IODispatcherDelayedMessage>(psubDispatcher);
perSubscrBus.Subscribe<ClientMessage.NotHandled>(psubDispatcher);
_mainBus.Subscribe(perSubscrQueue.WidenFrom<SystemMessage.StateChangeMessage, Message>());
_mainBus.Subscribe(perSubscrQueue.WidenFrom<TcpMessage.ConnectionClosed, Message>());
_mainBus.Subscribe(perSubscrQueue.WidenFrom<ClientMessage.CreatePersistentSubscriptionToStream, Message>());
Expand Down Expand Up @@ -1229,7 +1229,7 @@ public class ClusterVNode<TStreamId> :
//TODO CC can have multiple threads working on subscription if partition
var consumerStrategyRegistry = new PersistentSubscriptionConsumerStrategyRegistry(_mainQueue, _mainBus,
additionalPersistentSubscriptionConsumerStrategyFactories);
var persistentSubscription = new PersistentSubscriptionService<TStreamId>(perSubscrQueue, readIndex, ioDispatcher,
var persistentSubscription = new PersistentSubscriptionService<TStreamId>(perSubscrQueue, readIndex, psubDispatcher,
_mainQueue, consumerStrategyRegistry);
perSubscrBus.Subscribe<SystemMessage.BecomeShuttingDown>(persistentSubscription);
perSubscrBus.Subscribe<SystemMessage.BecomeLeader>(persistentSubscription);
Expand Down Expand Up @@ -1258,6 +1258,12 @@ public class ClusterVNode<TStreamId> :

// STORAGE SCAVENGER
ScavengerFactory scavengerFactory;
var scavengerDispatcher = new IODispatcher(_mainQueue, new PublishEnvelope(MainQueue));
timothycoleman marked this conversation as resolved.
Show resolved Hide resolved
_mainBus.Subscribe<ClientMessage.ReadStreamEventsBackwardCompleted>(scavengerDispatcher.BackwardReader);
_mainBus.Subscribe<ClientMessage.NotHandled>(scavengerDispatcher.BackwardReader);
_mainBus.Subscribe<ClientMessage.WriteEventsCompleted>(scavengerDispatcher.Writer);
_mainBus.Subscribe<IODispatcherDelayedMessage>(scavengerDispatcher);
_mainBus.Subscribe<ClientMessage.NotHandled>(scavengerDispatcher);

var newScavenge = true;
if (newScavenge) {
Expand Down Expand Up @@ -1367,7 +1373,7 @@ public class ClusterVNode<TStreamId> :
logger: logger,
unsafeIgnoreHardDeletes: options.Database.UnsafeIgnoreHardDelete);

var scavengePointSource = new ScavengePointSource(logger, ioDispatcher);
var scavengePointSource = new ScavengePointSource(logger, scavengerDispatcher);

return new Scavenger<TStreamId>(
logger: logger,
Expand Down Expand Up @@ -1416,7 +1422,7 @@ public class ClusterVNode<TStreamId> :
var scavengerLogManager = new TFChunkScavengerLogManager(
nodeEndpoint: NodeInfo.HttpEndPoint.ToString(),
scavengeHistoryMaxAge: TimeSpan.FromDays(options.Database.ScavengeHistoryMaxAge),
ioDispatcher: ioDispatcher);
ioDispatcher: scavengerDispatcher);

var storageScavenger = new StorageScavenger(
logManager: scavengerLogManager,
Expand Down