Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically log esdb version on each node #3882

Conversation

dhingrak
Copy link
Contributor

@linear
Copy link

linear bot commented Jun 27, 2023

DB-177 Periodically log the EventStore version on Single Node

DB-139 started this but won't work for a single node deployment. Could consider using the timer service to trigger

@dhingrak
Copy link
Contributor Author

This PR is using the FakeLogger() which is created in PR #3855. I will resolve conflicts when the other PR 3555 merge.

@timothycoleman timothycoleman self-requested a review June 29, 2023 11:11
@timothycoleman
Copy link
Contributor

tests need adjusting i think. space in 'eventstore'

Expected: "Current version of EventStore is : "0.0.0.0" " But was: "Current version of Event Store is : "0.0.0.0" " -----------------------------------^

@dhingrak dhingrak force-pushed the kunaldhingra/db-177-periodically-log-the-eventstore-version-on-single-node branch from 3404708 to 23eb3c1 Compare June 29, 2023 14:34
@timothycoleman
Copy link
Contributor

this can be rebased now that the other pr that uses the fake logger is merged

@dhingrak dhingrak force-pushed the kunaldhingra/db-177-periodically-log-the-eventstore-version-on-single-node branch from 23eb3c1 to 4cfe89e Compare July 3, 2023 14:49
Copy link
Contributor

@timothycoleman timothycoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks looks good 👍

@hayley-jean hayley-jean merged commit 4768312 into master Jul 4, 2023
5 of 8 checks passed
@hayley-jean hayley-jean deleted the kunaldhingra/db-177-periodically-log-the-eventstore-version-on-single-node branch July 4, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants