Remove ConfigureAwait(false) calls and analyzer (DB-549) #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think these were originally added because there were some places in the code (mostly in the client and embedded client) where they there necessary. These days the client lives in another repository and there is no embedded client. There aren't any synchronization contexts to forget in the server code and none of the async paths are hot enough that we need the cycles saved by not checking for a sync context, so we can remove the ugly calls.
DB-549 Remove configure await false calls from server
They are ugly and we dont need them any more. I think these were originally added because there were some places in the code (mostly in the client and embedded client) where they there necessary. These days the client lives in another repository and there is no embedded client. There aren't any synchronization contexts to forget in the server code and none of the async paths are hot enough that we need the cycles saved by not checking for a sync context, so we can remove the ugly calls. |
thefringeninja
approved these changes
Nov 27, 2023
hayley-jean
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed: Unncessary code
I think these were originally added because there were some places in the code (mostly in the client and embedded client) where they there necessary. These days the client lives in another repository and there is no embedded client. There aren't any synchronization contexts to forget in the server code and none of the async paths are hot enough that we need the cycles saved by not checking for a sync context, so we can remove the ugly calls.