Add the 5 seconds shutdown timeout for HostOptions to match with the ESDB shutdown timeout #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothycoleman
approved these changes
Jan 5, 2024
timothycoleman
deleted the
kunaldhingra/db-588-investigate-esdb-not-shutting-down-quickly-with-slow
branch
hayley-jean
pushed a commit
that referenced
this pull request
May 30, 2024
…ate-esdb-not-shutting-down-quickly-with-slow Add the 5 seconds shutdown timeout for HostOptions to match with the ESDB shutdown timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Explicitly set the shutdown timeout to 5s, which was default in previous dotnet versions. Behaviour unchanged since previous release
Fixes https://linear.app/eventstore/issue/DB-588/investigate-esdb-not-shutting-down-quickly-with-slow-subscriptions
Currently the default shutdown timeout for HostOptions is 30 seconds. The goal of this PR is to set the timeout to 5 seconds.