Expect CancelledError when node is terminated #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
w1am/dev-231-remove-try-catch-in-mid-stream-and-write-after-end-test
branch
from
983e87a
to
f086387
Compare
George-Payne
requested changes
Feb 21, 2024
…into w1am/dev-231-remove-try-catch-in-mid-stream-and-write-after-end-test
George-Payne
requested changes
Feb 28, 2024
w1am
force-pushed
the
w1am/dev-231-remove-try-catch-in-mid-stream-and-write-after-end-test
branch
4 times, most recently
from
2f3cbe3
to
39a3d2f
Compare
w1am
force-pushed
the
w1am/dev-231-remove-try-catch-in-mid-stream-and-write-after-end-test
branch
from
39a3d2f
to
f195714
Compare
George-Payne
approved these changes
Feb 29, 2024
w1am
deleted the
w1am/dev-231-remove-try-catch-in-mid-stream-and-write-after-end-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Expect a
CancelledErrorerror when a node connection is abruptly terminated.The default value of ShutdownTimeout in ESDB is now explicitly set to 5s, which was the default value for ESDB versions before v24.x. The value was recently changed to 30s in recent .NET releases, but this change was causing some issues with subscriptions. See more info here.