Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [New Query Planner] Add support for joins. #1260

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Aug 11, 2023

This PR adds support for joins to the new query planner, including pushing the hash-based repartition insertion from the logical plan construction stage into the planning stage.

This PR is stacked on #1258, so the true diff is contained in commit 6b1e263.

@github-actions github-actions bot added the enhancement New feature or request label Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1260 (f930c78) into main (ddd3e7b) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   87.63%   87.61%   -0.03%     
==========================================
  Files          62       62              
  Lines        6027     6047      +20     
==========================================
+ Hits         5282     5298      +16     
- Misses        745      749       +4     
Files Changed Coverage Δ
daft/execution/execution_step.py 93.68% <ø> (-0.02%) ⬇️
daft/dataframe/dataframe.py 88.98% <83.33%> (-0.17%) ⬇️
daft/logical/rust_logical_plan.py 84.45% <86.95%> (+0.73%) ⬆️
daft/execution/physical_plan.py 94.58% <100.00%> (-0.02%) ⬇️
daft/execution/rust_physical_plan_shim.py 98.14% <100.00%> (+0.18%) ⬆️
daft/logical/builder.py 79.45% <100.00%> (-1.32%) ⬇️
daft/logical/logical_plan.py 79.43% <100.00%> (ø)
daft/table/table.py 88.84% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@clarkzinzow clarkzinzow merged commit 6a12680 into main Aug 14, 2023
18 checks passed
@clarkzinzow clarkzinzow deleted the clark/joins branch August 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant