Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] [New Query Planner] Add support for Explode. #1258

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[FEAT] [New Query Planner] Add support for Explode. #1258

merged 1 commit into from
Aug 14, 2023

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Aug 11, 2023 •
edited
Loading

This PR adds support for df.explode() in the new query planner.

@github-actions github-actions bot added the enhancement New feature or request label Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #1258 (69d5cc3) into main (48b46b3) will increase coverage by 0.06%.
The diff coverage is 96.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   87.57%   87.63%   +0.06%     
==========================================
  Files          62       62              
  Lines        6003     6027      +24     
==========================================
+ Hits         5257     5282      +25     
+ Misses        746      745       -1
Files Changed Coverage Δ
daft/execution/rust_physical_plan_shim.py 97.95% <92.30%> (-2.05%) ⬇️
daft/logical/rust_logical_plan.py 83.72% <100.00%> (+2.36%) ⬆️

... and 1 file with indirect coverage changes

@clarkzinzow clarkzinzow mentioned this pull request Aug 11, 2023
Merged
@clarkzinzow clarkzinzow mentioned this pull request Aug 12, 2023
Merged
1 task
@clarkzinzow clarkzinzow merged commit ddd3e7b into main Aug 14, 2023
20 checks passed
@clarkzinzow clarkzinzow deleted the clark/explode branch August 14, 2023 15:21
clarkzinzow added a commit that referenced this pull request Aug 14, 2023
@clarkzinzow
[FEAT] [New Query Planner] Add support for joins. (#1260)
6a12680 
This PR adds support for joins to the new query planner, including
pushing the hash-based repartition insertion from the logical plan
construction stage into the planning stage.

This PR is stacked on #1258, so
the true diff is contained in commit
6b1e263.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcharleslin xcharleslin Awaiting requested review from xcharleslin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clarkzinzow