DynamicRayRunner #412
Merged
DynamicRayRunner #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e372b1.
This was referenced Jan 4, 2023
xcharleslin
added a commit
that referenced
this pull request
Jan 5, 2023
…r task management (#418) Optimizations in #412: - Zero dynamic ray.remote registrations (they all happen at module initialization). This is a strict improvement over RayRunner. Optimizations in this PR: - Metadata is computed and retrieved as needed, instead of for all partitions. This brings down metadata overhead vs RayRunner to negligible. - Drop asyncio and move entirely to ray.wait for task management. This should correctly minimize idle time by the dispatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A working Ray Runner that uses DynamicSchedule.
Slight performance regression against existing RayRunner, likely since this new runner needs partition metadata and makes a second ray.get call per partition to get it.