Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicRayRunner optimizations: metadata fetch on demand; ray.wait for task management #418

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

xcharleslin
Copy link
Contributor

@xcharleslin xcharleslin commented Jan 4, 2023

Optimizations in #412:

  • Zero dynamic ray.remote registrations (they all happen at module initialization). This is a strict improvement over RayRunner.

Optimizations in this PR:

  • Metadata is computed and retrieved as needed, instead of for all partitions. This brings down metadata overhead vs RayRunner to negligible.
  • Drop asyncio and move entirely to ray.wait for task management. This should correctly minimize idle time by the dispatcher.

@xcharleslin xcharleslin changed the title WIP dynamicrayrunner optimizations Various DynamicRayRunner optimizations. Jan 5, 2023
@xcharleslin xcharleslin marked this pull request as ready for review January 5, 2023 01:20
@xcharleslin xcharleslin changed the title Various DynamicRayRunner optimizations. DynamicRayRunner optimizations: metadata fetch on demand; ray.wait for task management Jan 5, 2023
@xcharleslin xcharleslin merged commit e99c245 into main Jan 5, 2023
@xcharleslin xcharleslin deleted the charles/raymetas branch January 5, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant