Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix Behavior in Search Sorted (Partitioning) for Nulls and NaNs #545

Merged
merged 8 commits into from
Feb 3, 2023
Merged

[bugfix] Fix Behavior in Search Sorted (Partitioning) for Nulls and NaNs #545

merged 8 commits into from
Feb 3, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Feb 3, 2023 •
edited
Loading

  • Here we fix the behavior of nulls and nans in Search Sorted.
  • fixed a bug for Nulls when sorting in reverse
  • set ordering of nans to be value < nan < null
  • fix bug when sorting in reverse that led to bisect left behavior rather than bisect right

@samster25 samster25 marked this pull request as ready for review February 3, 2023 06:39
@samster25 samster25 changed the title Sammy/search sorted nan and null handling Fix Behavior in Search Sorted (Partitioning) for Nulls and NaNs Feb 3, 2023
@samster25 samster25 changed the title Fix Behavior in Search Sorted (Partitioning) for Nulls and NaNs [bugfix] Fix Behavior in Search Sorted (Partitioning) for Nulls and NaNs Feb 3, 2023
@samster25 samster25 enabled auto-merge (squash) February 3, 2023 06:43
@samster25 samster25 merged commit 53ec096 into main Feb 3, 2023
@samster25 samster25 deleted the sammy/search-sorted-nan-and-null-handling branch February 3, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samster25