Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Joins when we have duplicate names from each source #592

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Feb 14, 2023

  • When we join and left and right have different names but the same value
  • in vPartition Join: when we are joining, we can clobber names from the left side with the right blocks.

@samster25 samster25 changed the title Sammy/fix self join bug 442 Fixes Joins when we have duplicate names from each source Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #592 (335bf5b) into main (5181138) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   78.50%   78.78%   +0.27%     
==========================================
  Files         102      102              
  Lines        8599     8611      +12     
==========================================
+ Hits         6751     6784      +33     
+ Misses       1848     1827      -21     
Impacted Files Coverage Δ
daft/logical/logical_plan.py 78.17% <100.00%> (ø)
daft/runners/partitioning.py 94.37% <100.00%> (+0.15%) ⬆️
daft/expressions.py 90.67% <0.00%> (-1.20%) ⬇️
daft/runners/blocks.py 85.42% <0.00%> (+0.29%) ⬆️
daft/runners/ray_runner.py 58.22% <0.00%> (+11.11%) ⬆️

@samster25 samster25 merged commit 0c8164b into main Feb 14, 2023
@samster25 samster25 deleted the sammy/fix-self-join-bug-442 branch February 14, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix self-joins wrongly omitting columns
1 participant