Mirror changes currently PR'd to frontend-ssr #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
commented
May 29, 2020
| #. defaultMessage is: | ||
| #. Book ISBN | ||
| #: public/messages/src/editor/plugins/citation-modal/citation-modal.json | ||
| msgid "Book ISBN" |
There was a problem hiding this comment.
@FortisFortuna here's an area we might be losing translation data that was previously included
dawsbot
commented
May 29, 2020
| @@ -73,7 +73,7 @@ msgstr "3개월" | |||
| #. 6 MONTHS | |||
| #: public/messages/src/app/containers/dashboard/dashboard_component.json | |||
| msgid "6 MONTHS" | |||
| msgstr "6 개월" | |||
There was a problem hiding this comment.
Another example of what seems like a regression
dawsbot
commented
May 29, 2020
| @@ -2581,7 +2581,7 @@ msgid "" | |||
| "University. When he is not working on knowledge projects, he plays the Irish " | |||
| "fiddle and homeschools his two boys." | |||
| msgstr "" | |||
| "Larry Sange 是一名知识类项目开发人员。他因联合创立了维基百科而广为人知他拥" | |||
| "Larry Sanger 是一名知识类项目开发人员。他因联合创立了维基百科而广为人知他拥" | |||
There was a problem hiding this comment.
This zh file seems fully accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.