fix: chain promise on stream close #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCrosson
approved these changes
Apr 20, 2022
| @@ -62,7 +62,13 @@ class Binary { | |||
|
|
|||
| return axios({ ...fetchOptions, url: this.url, responseType: "stream" }) | |||
| .then(res => { | |||
| res.data.pipe(tar.x({ strip: 1, C: this.installDirectory })); | |||
| return new Promise((resolve, reject) => { | |||
| const sink = res.data.pipe( | |||
There was a problem hiding this comment.
Looks good to me! I had to double-check that pipe returns the Writable, but the docs indicate that it does 👍
thanks to [EricCrosson](https://github.com/EricCrosson) for the PR
EverlastingBugstopper
force-pushed
the
avery/fix-chain
branch
from
442fbe9
to
58f11f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally opened by @EricCrosson but the lints failed, wanted to get this in though since it's super important and helpful