-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable filter works with table api(not in the footer) #73
Merged
Evertras
merged 5 commits into
Evertras:main
from
alswl:feat/enable-api-controlled-filter
May 21, 2022
Merged
enable filter works with table api(not in the footer) #73
Evertras
merged 5 commits into
Evertras:main
from
alswl:feat/enable-api-controlled-filter
May 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evertras
reviewed
May 6, 2022
Evertras
reviewed
May 6, 2022
Evertras
reviewed
May 6, 2022
Evertras
reviewed
May 6, 2022
Evertras
reviewed
May 6, 2022
Evertras
reviewed
May 6, 2022
I generally agree with the idea of this, just some things that I think we should clarify. |
Evertras
reviewed
May 8, 2022
Evertras
reviewed
May 8, 2022
Co-authored-by: Brandon Fulljames <bfullj@gmail.com>
Co-authored-by: Brandon Fulljames <bfullj@gmail.com>
ping @Evertras |
Ah, sorry! LGTM now, will merge/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have keyword filtering, but this can only be displayed in the footer of the form. If I want a form without a footer, or if I want to have the ability to manually control the filtering feature, I need an API to connect to the form to manipulate it.
Before:
New sytle: