Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCS and LD for NSString #24

Closed
aceisScope opened this issue Nov 29, 2013 · 4 comments
Closed

LCS and LD for NSString #24

aceisScope opened this issue Nov 29, 2013 · 4 comments

Comments

@aceisScope
Copy link
Contributor

hi i once wrote longest common subsequence and Levenshtein distanc algorithm as an NSString category in this tiny reop but when i came across this repo of yours i feel that maybe i could add the two methods into your project. is it okay for me to make a pull request then?
@EvgenyKarkan
Copy link
Owner

Hi!
Thank you for your contribution. Glad you like this repo.
Yes, feel free to make pull request with your methods.
Best wishes!

@EvgenyKarkan
Copy link
Owner

Merged your pull request!
Thank you for contribution.
Would you please be so kind to add to main.m file examples of how to test those methods (with inputs and outputs).
And I will update README with 2 new algos right now.
Thanks ;)

@aceisScope
Copy link
Contributor Author

Added test cased to main.m

@EvgenyKarkan
Copy link
Owner

Closes #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aceisScope @EvgenyKarkan