Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Fix non-json error handling #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature - Fix non-json error handling #57

wants to merge 3 commits into from

Conversation

WouterJanson
Copy link
Contributor

@WouterJanson WouterJanson commented Nov 25, 2020 •
edited
Loading

Fixes #56

BerendJonkman
BerendJonkman reviewed Nov 25, 2020
View reviewed changes
src/SignhostAPIClient/Rest/JsonStringExtensions.cs
@@ -0,0 +1,40 @@
using Newtonsoft.Json;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to use #nullable enable here?

Copy link
Contributor Author

@WouterJanson WouterJanson Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still at C# 7.3 and I don't know if we want to upgrade to C# 8.0 or greater just jet because it's a client library.

ATimmeh33
ATimmeh33 requested changes Nov 25, 2020
View reviewed changes
src/SignhostAPIClient/Rest/ErrorHandling/HttpResponseMessageErrorHandlingExtensions.cs
Comment on lines +99 to +100
case (HttpStatusCode)429:
throw new RateLimitException(errorMessage);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be separated with empty lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8215dcb

src/SignhostAPIClient/Rest/DataObjects/SignhostError.cs
@@ -0,0 +1,20 @@
using Newtonsoft.Json;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nullable enable (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57 (comment)

src/SignhostAPIClient/Rest/JsonStringExtensions.cs
@@ -0,0 +1,40 @@
using Newtonsoft.Json;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nullable enable (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57 (comment)

src/SignhostAPIClient/Rest/ErrorHandling/RateLimitException.cs
@@ -0,0 +1,21 @@
using System;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nullable enable (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57 (comment)

@WouterJanson WouterJanson force-pushed the feature/fix-nonjson-error-handling branch from 8215dcb to 37db712 Compare November 25, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BerendJonkman BerendJonkman BerendJonkman left review comments

@ATimmeh33 ATimmeh33 Awaiting requested review from ATimmeh33

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw Signhost Exception on 429
3 participants
@WouterJanson @ATimmeh33 @BerendJonkman