upgrade to Julia 1.x #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github action supports more concurrent jobs than travis CI
change indexes to indices change Range to AbstractRange use Base.showarg update CI and README fix basic deprecations fix showcompact deprecation fix channel ops and tests fix convert ops work on mapfun ops
* add Project.toml * update test for cache and minor fix * update test for rotation and minor fix * update flipdm to reverse JuliaLang/julia#26369 * update test for crop and minor fix * update test for resize * update test for scale and minor fix * update test for zoom and minor fix * WIP: update test for distortion and minor fix * update test for either and minor fix * fix pipeline test * update summary reference for distortedview * WIP: fix tests for augment and operations * drop julia 0.7 and update CI * use FileIO v1.1.0 JuliaIO/FileIO.jl#245 * add 1.x tests to CI * revert back unnecessary changes * test windows in travis * fix randomly failed test cases for inacuraccy reasons * update to julia 1.1 * maybe_copy doesn't explain its usage * replace Slice by OffsetArrays.IdentityUnitRange JuliaArrays/OffsetArrays.jl#62 * update to julia 1.2 -- part I * WIP: update to julia 1.2 -- part II detect some type instable test cases, only the outmost wrapper is instable here * unify how types are displayed Only meta operations such as Either, Pipeline doesn't have Agumentor prefix * add more test versions * move safe_rand to compat.jl rand is thread-safe in julia 1.3 * don't allow failures for julia 1.3 * fix commit "WIP: update 1.0" * use explicit and intuitive CartesianIndex(1, 1) * add method specialization for tweight * allow FileIO 1.2 * fix type instability for Either * update reference for FixedPointNumbers v0.7 * try: relax equality check for scale * restore test cases in tst_scale.jl * Revert "add method specialization for tweight" This reverts commit a698382. * Augmentor v0.6.0-pre
|
Commits 40820af and 03d97a0 were pushed to master and rebased to this branch; then I realized that they won't actually work before this PR is ready. To disable daily notification of failed GitHub action jobs, I deleted these two commits from the master branch so that there will be no scheduled jobs running. To keep track of history, this PR shouldn't be merged with "squash and merge" option. |
Evizero
approved these changes
Jan 30, 2020
| @@ -93,7 +93,7 @@ augment(img, ElasticDistortion(15, 15; scale = 0.1)) | |||
| # distort everything more smoothly. | |||
| augment(img, ElasticDistortion(10, 10; sigma = 4, iter=3, border=true)) | |||
| ``` | |||
| """ -> | |||
| """ | |||
If upstream package (e.g., Interpolations, FixedPointNumbers) doesn't provide such specialization, then we add one here. This trick avoids incremental compilation warnings
OffsetArray might hit accuracy issue for affine Some affine operations (e.g., scale and zoom) might hit accuracy issues when images are upsampled This is a temporarily workaround to issue #38 (by disabling the tests)
johnnychen94
changed the title
|
Since this branch is functioning now with all deprecations fixed, I'm merging this branch to master. From now on, compat upgrades(e.g., OffsetArrays 1.0 is a breaking change) and new features can be added to the master branch separately. |
|
@Evizero since most CI are moved to github action, can you uninstall appveyor? Submitting coverage report via github action doesn't work for PRs from other forks. (It's an upstream github action issue), hence travis is still required to upload coverage report |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update work is split into several PRs(e.g., #27, #31) and will be merged into this PR/branch first. There will be a lot of changes, so it's not suitable to directly review this.
Basically, the roads are:
When all things get settled done, I will merge this branch into master.