Fix incorrect update of components

1. Fix compress/expand table action button (role-mining operation table)
Evolveum · Sep 4, 2023 · 84d32db · 84d32db
1 parent 6fb83ef
commit 84d32db
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 21 deletions.
diff --git a/...dpoint/gui/impl/page/admin/role/mining/page/panel/cluster/PageClusterOperationsPanel.java b/...dpoint/gui/impl/page/admin/role/mining/page/panel/cluster/PageClusterOperationsPanel.java
@@ -211,7 +211,6 @@ protected void onPerform(AjaxRequestTarget ajaxRequestTarget) {
                 compress = !compress;
                 loadMiningTableData();
                 updateMiningTable(ajaxRequestTarget, false);
-                ajaxRequestTarget.add(this);
             }
 
             @Override

diff --git a/...veum/midpoint/gui/impl/page/admin/role/mining/page/wizard/ProcessModeChoiceStepPanel.java b/...veum/midpoint/gui/impl/page/admin/role/mining/page/wizard/ProcessModeChoiceStepPanel.java
@@ -81,8 +81,8 @@ protected void onTileClickPerformed(ProcessMode value, AjaxRequestTarget target)
 
 
     public enum ProcessMode implements TileEnum {
-        ROLE(CLASS_OBJECT_ROLE_ICON),
-        USER(CLASS_OBJECT_USER_ICON);
+        USER(CLASS_OBJECT_USER_ICON),
+        ROLE(CLASS_OBJECT_ROLE_ICON);
 
         private final String icon;
 

diff --git a/.../evolveum/midpoint/gui/impl/page/admin/role/mining/tables/RoleAnalysisRoleBasedTable.java b/.../evolveum/midpoint/gui/impl/page/admin/role/mining/tables/RoleAnalysisRoleBasedTable.java
@@ -406,7 +406,6 @@ public CompositedIcon getIcon() {
                     @Override
                     protected void onSubmit(AjaxRequestTarget target) {
                         onPerform(target);
-                        target.add(this);
                     }
 
                     @Override

diff --git a/.../evolveum/midpoint/gui/impl/page/admin/role/mining/tables/RoleAnalysisUserBasedTable.java b/.../evolveum/midpoint/gui/impl/page/admin/role/mining/tables/RoleAnalysisUserBasedTable.java
@@ -18,19 +18,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import com.evolveum.midpoint.common.mining.utils.values.RoleAnalysisChunkMode;
-import com.evolveum.midpoint.gui.api.GuiStyleConstants;
-import com.evolveum.midpoint.gui.impl.component.AjaxCompositedIconButton;
-import com.evolveum.midpoint.gui.impl.component.icon.CompositedIcon;
-import com.evolveum.midpoint.gui.impl.component.icon.CompositedIconBuilder;
-import com.evolveum.midpoint.gui.impl.component.icon.LayeredIconCssStyle;
-
-import com.evolveum.midpoint.gui.impl.util.DetailsPageUtil;
-import com.evolveum.midpoint.web.component.AjaxCompositedIconSubmitButton;
-import com.evolveum.midpoint.web.component.AjaxIconButton;
-
-import com.evolveum.midpoint.web.util.OnePageParameterEncoder;
-
 import org.apache.wicket.Component;
 import org.apache.wicket.ajax.AjaxRequestTarget;
 import org.apache.wicket.behavior.AttributeAppender;
@@ -46,34 +33,42 @@
 import org.apache.wicket.model.LoadableDetachableModel;
 import org.apache.wicket.model.Model;
 import org.apache.wicket.model.util.ListModel;
+import org.apache.wicket.request.mapper.parameter.PageParameters;
 
 import com.evolveum.midpoint.common.mining.objects.chunk.MiningOperationChunk;
 import com.evolveum.midpoint.common.mining.objects.chunk.MiningRoleTypeChunk;
 import com.evolveum.midpoint.common.mining.objects.chunk.MiningUserTypeChunk;
 import com.evolveum.midpoint.common.mining.objects.detection.DetectedPattern;
+import com.evolveum.midpoint.common.mining.utils.values.RoleAnalysisChunkMode;
 import com.evolveum.midpoint.common.mining.utils.values.RoleAnalysisOperationMode;
 import com.evolveum.midpoint.common.mining.utils.values.RoleAnalysisSortMode;
-import com.evolveum.midpoint.gui.api.model.LoadableModel;
+import com.evolveum.midpoint.gui.api.GuiStyleConstants;
 import com.evolveum.midpoint.gui.api.page.PageBase;
 import com.evolveum.midpoint.gui.api.util.GuiDisplayTypeUtil;
+import com.evolveum.midpoint.gui.impl.component.AjaxCompositedIconButton;
+import com.evolveum.midpoint.gui.impl.component.icon.CompositedIcon;
+import com.evolveum.midpoint.gui.impl.component.icon.CompositedIconBuilder;
+import com.evolveum.midpoint.gui.impl.component.icon.LayeredIconCssStyle;
 import com.evolveum.midpoint.gui.impl.page.admin.role.mining.model.BusinessRoleApplicationDto;
 import com.evolveum.midpoint.gui.impl.page.admin.role.mining.model.BusinessRoleDto;
 import com.evolveum.midpoint.gui.impl.page.admin.role.mining.page.panel.cluster.MembersDetailsPanel;
+import com.evolveum.midpoint.gui.impl.util.DetailsPageUtil;
 import com.evolveum.midpoint.gui.impl.util.IconAndStylesUtil;
 import com.evolveum.midpoint.prism.PrismObject;
 import com.evolveum.midpoint.schema.constants.ObjectTypes;
 import com.evolveum.midpoint.schema.result.OperationResult;
 import com.evolveum.midpoint.schema.util.ObjectTypeUtil;
+import com.evolveum.midpoint.web.component.AjaxCompositedIconSubmitButton;
+import com.evolveum.midpoint.web.component.AjaxIconButton;
 import com.evolveum.midpoint.web.component.data.RoleAnalysisTable;
 import com.evolveum.midpoint.web.component.data.column.AjaxLinkPanel;
 import com.evolveum.midpoint.web.component.data.column.AjaxLinkTruncatePanelAction;
 import com.evolveum.midpoint.web.component.data.column.IconColumn;
 import com.evolveum.midpoint.web.component.data.column.LinkIconPanelStatus;
 import com.evolveum.midpoint.web.component.util.RoleMiningProvider;
+import com.evolveum.midpoint.web.util.OnePageParameterEncoder;
 import com.evolveum.midpoint.xml.ns._public.common.common_3.*;
 
-import org.apache.wicket.request.mapper.parameter.PageParameters;
-
 public class RoleAnalysisUserBasedTable extends Panel {
 
     private static final String ID_DATATABLE = "datatable_extra";
@@ -429,7 +424,6 @@ public CompositedIcon getIcon() {
                     @Override
                     protected void onSubmit(AjaxRequestTarget target) {
                         onPerform(target);
-                        target.add(this);
                     }
 
                     @Override