Role analysis add useful method into rbac generator

Evolveum · Jun 26, 2024 · f042480 · f042480
1 parent 12874a5
commit f042480
Show file tree

Hide file tree

Showing 4 changed files with 85 additions and 26 deletions.
diff --git a/...c/main/java/com/evolveum/midpoint/ninja/action/mining/generator/context/ImportAction.java b/...c/main/java/com/evolveum/midpoint/ninja/action/mining/generator/context/ImportAction.java
@@ -449,26 +449,31 @@ public static PolyStringType getNameFromSet(PolyStringType initialName, Set<Stri
         return PolyStringType.fromOrig(name);
     }
 
-    public static   <V> void addExtensionValue(
-            Containerable extContainer, String itemName, V... values) throws SchemaException {
+    public static <V> void addExtensionValue(
+            Containerable extContainer, String itemName, V... values) {
         PrismContainerValue<?> pcv = extContainer.asPrismContainerValue();
         ItemDefinition<?> itemDefinition =
                 pcv.getDefinition().findItemDefinition(new ItemName(itemName));
 
-        if (itemDefinition instanceof PrismReferenceDefinition) {
-            PrismReference ref = (PrismReference) itemDefinition.instantiate();
-            for (V value : values) {
-                ref.add(value instanceof PrismReferenceValue
-                        ? (PrismReferenceValue) value
-                        : ((Referencable) value).asReferenceValue());
+        try {
+            if (itemDefinition instanceof PrismReferenceDefinition) {
+                PrismReference ref = (PrismReference) itemDefinition.instantiate();
+                for (V value : values) {
+                    ref.add(value instanceof PrismReferenceValue
+                            ? (PrismReferenceValue) value
+                            : ((Referencable) value).asReferenceValue());
+                }
+                pcv.add(ref);
+            } else {
+                //noinspection unchecked
+                PrismProperty<V> property = (PrismProperty<V>) itemDefinition.instantiate();
+                property.setRealValues(values);
+                pcv.add(property);
             }
-            pcv.add(ref);
-        } else {
-            //noinspection unchecked
-            PrismProperty<V> property = (PrismProperty<V>) itemDefinition.instantiate();
-            property.setRealValues(values);
-            pcv.add(property);
+        } catch (SchemaException e) {
+            throw new RuntimeException("Cloud not add extension value", e);
         }
+
     }
 
 }
diff --git a/.../java/com/evolveum/midpoint/ninja/action/mining/generator/context/RbacBasicStructure.java b/.../java/com/evolveum/midpoint/ninja/action/mining/generator/context/RbacBasicStructure.java
@@ -9,6 +9,8 @@
 import java.util.List;
 import java.util.Set;
 
+import com.evolveum.midpoint.xml.ns._public.common.common_3.UserType;
+
 import org.jetbrains.annotations.NotNull;
 
 import com.evolveum.midpoint.ninja.action.mining.generator.GeneratorOptions;
@@ -47,4 +49,6 @@ void buildAndImportObjects(
             @NotNull GeneratorOptions generatorOptions,
             int total, Set<String> names,
             @NotNull OperationResult result);
+
+    void additionalChanges(UserType user);
 }
diff --git a/...om/evolveum/midpoint/ninja/action/mining/generator/context/RbacObjectCategoryBuilder.java b/...om/evolveum/midpoint/ninja/action/mining/generator/context/RbacObjectCategoryBuilder.java
@@ -6,6 +6,17 @@
  */
 package com.evolveum.midpoint.ninja.action.mining.generator.context;
 
+import static com.evolveum.midpoint.ninja.action.mining.generator.context.ImportAction.importUserAndResolveAuxRoles;
+import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacGeneratorUtils.*;
+import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacObjectCategoryProcessor.*;
+import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacObjectCategoryProcessor.Category.*;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import org.jetbrains.annotations.NotNull;
+
 import com.evolveum.midpoint.ninja.action.mining.generator.GeneratorOptions;
 import com.evolveum.midpoint.ninja.action.mining.generator.object.InitialBusinessRole;
 import com.evolveum.midpoint.ninja.action.mining.generator.object.InitialObjectsDefinition;
@@ -15,18 +26,6 @@
 import com.evolveum.midpoint.xml.ns._public.common.common_3.UserType;
 import com.evolveum.prism.xml.ns._public.types_3.PolyStringType;
 
-import org.jetbrains.annotations.NotNull;
-
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Random;
-
-import static com.evolveum.midpoint.ninja.action.mining.generator.context.ImportAction.importUserAndResolveAuxRoles;
-import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacGeneratorUtils.*;
-import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacGeneratorUtils.createRoleAssignment;
-import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacObjectCategoryProcessor.*;
-import static com.evolveum.midpoint.ninja.action.mining.generator.context.RbacObjectCategoryProcessor.Category.*;
-
 public class RbacObjectCategoryBuilder {
 
     /**
@@ -109,6 +108,13 @@ public String getTitle() {
             return null;
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Mike");
+        }
+
         @Override
         protected String getDisplayName() {
             return REGULR.getDisplayName();
@@ -179,6 +185,13 @@ public String getTitle() {
             return getRandomlyJobTitlesWithNone();
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Jan");
+        }
+
         @Override
         protected String getDisplayName() {
             return SEMI_REGULAR.getDisplayName();
@@ -216,6 +229,13 @@ public String getTitle() {
             return getRandomlyJobTitlesWithNone();
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Jozef");
+        }
+
         @Override
         public String getCorrespondingArchetypeOid() {
             return InitialObjectsDefinition.Archetypes.IRREGULAR_USER.getOidValue();
@@ -308,6 +328,13 @@ public String getTitle() {
             return "manager";
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Peter");
+        }
+
         @Override
         protected String getDisplayName() {
             return MANAGERS.getDisplayName();
@@ -387,6 +414,13 @@ public String getTitle() {
             return null;
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Slavo");
+        }
+
         @Override
         protected String getDisplayName() {
             return SALES.getDisplayName();
@@ -449,6 +483,13 @@ public String getTitle() {
             return null;
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Karol");
+        }
+
         @Override
         protected String getDisplayName() {
             return SECURITY_OFFICERS.getDisplayName();
@@ -511,6 +552,13 @@ public String getTitle() {
             return null;
         }
 
+        @Override
+        public void additionalChanges(UserType user) {
+//            user.extension(new ExtensionType());
+//            ExtensionType ext = user.getExtension();
+//            addExtensionValue(ext, "hatSize", "Clark");
+        }
+
         @Override
         protected String getDisplayName() {
             return CONTRACTORS.getDisplayName();

diff --git a/...c/main/java/com/evolveum/midpoint/ninja/action/mining/generator/context/RbacUserType.java b/...c/main/java/com/evolveum/midpoint/ninja/action/mining/generator/context/RbacUserType.java
@@ -72,6 +72,8 @@ public UserType build(@NotNull UserType user) {
             }
         }
 
+        additionalChanges(user);
+
         InitialBusinessRole primaryRole = getPrimaryRole(true);
         if (primaryRole != null) {
             user.getAssignment().add(createRoleAssignment(primaryRole.getOidValue()));