New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate admin fix #308

Merged
merged 2 commits into from Sep 30, 2015

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Sep 28, 2015

  • Uses User checker from @handle_exceptions_for_ajax
  • Adds IntegrityError when Admin already exist
  • Tiny test clean-up
Julius O
Do not try to create duplicate admins
Throws IntegrityError HTTP 400.
@oliverroick

This comment has been minimized.

Show comment
Hide comment
@oliverroick

oliverroick Sep 28, 2015

Member

@mfc-julius Yes, it's more readable.

Member

oliverroick commented on 652abbe Sep 28, 2015

@mfc-julius Yes, it's more readable.

Julius O

@ghost ghost added the bug label Sep 28, 2015

@ghost ghost added this to the 0.8 milestone Sep 28, 2015

oliverroick added a commit that referenced this pull request Sep 30, 2015

@oliverroick oliverroick merged commit 3099e24 into master Sep 30, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@oliverroick oliverroick deleted the duplicate-admin-fix branch Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment