New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BGP-MUP SAFI and Extended Community #1142
Support for BGP-MUP SAFI and Extended Community #1142
Conversation
Hello @takehaya - Thank you very much for this patch, it looks pretty good! I will give it a longer review a bit later on. At first glance, and from previous experience, the main thing I can not change once the code is accepted is the name of the JSON attributes. Right now, I see a mix of spaces, underscores (but no hyphen 👍). I think the user experience would be better with consistent naming and usage of prefixes and suffixes. Also, I note the use of "parsed: true". I am not sure this is providing much. Was there a good reason for you to add this when checking for anything more than "raw" may achieve the same result? Once again thank you for this work. |
93023ed
to
97e4039
Compare
This commit supports BGP features required for Cplane in SRv6-MUP cf. https://datatracker.ietf.org/doc/html/draft-mpmz-bess-mup-safi-02
97e4039
to
57cccdc
Compare
Hi @thomas-mangin -san |
Hi @takehaya-san, arigato gozaimashita. |
I finished the review. All that is needed is a test for the feature, and I can merge! The program used for testing is You will need to change your configuration example to use 127.0.0.1 as a peer (it is already ibgp so good), define a You can find what is expected by running Then run You can then run That's it. Sorry for not telling you this earlier. |
Oh!! nice japanese! 😲 I got it. Please few a wait that i write by test code...:) |
I was told how to correctly say thank you by an old lady in a Tokyo shop 8 years ago when I visited the country for 10 days. I spend a week in Tokyo and then visited Kyoto, Osaka, the Nara Park and Himeji Castle - everyone was so nice, one of my best holidays :-) |
that "Arigato" is perfect 👏 so nice experience...! Actually, I'm planning to bring this code to IETF Hackathon 116 in Japan Yokohama this month. https://wiki.ietf.org/en/meeting/116/hackathon
I tried adding a test. please confirm 🙏 |
Yes, I came at the end of March, and the trees were beautiful. The code is merged 🥳 🍾 Thank you for all this work. I was wondering how you found your experience working with the code. Any issues? |
I see that in the log, the routes are presented as "insert mup:isd::100:100:10.0.1.0/24" - do you mind if it is changed to be the same syntax as the annonouce ipv4 section ? |
Please come to Japan again if you have the chance :) Thank you for your quick and polite review! 🍷 It was pretty well managed and readable code. It was great! (I liked that the documentation was fairly well maintained!)
of course ! |
This PR enables exaBGP to support BGP-MUP SAFI and Extended Community defined in draft-mpmz-bess-mup-safi-02.
SAFI value 85 is assigned by IANA as "BGP-MUP SAFI" https://www.iana.org/assignments/safi-namespace/safi-namespace.xhtml
BGP Transitive Extended Community Types 0x0c is assigned by IANA as "SRv6 MUP Extended Community" https://www.iana.org/assignments/bgp-extended-communities/bgp-extended-communities.xhtml
Usage: https://gist.github.com/takehaya/8170122cb7ff4c710775d02123903e70