Removing forcing Attribute.CODE.ATOMIC_AGGREGATE into _generate_json loop. #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_generate_json
inexabgp.bgp.message.update.attribute.attributes.Attributes
loops through the keys of the dict given, plusAttribute.CODE.ATOMIC_AGGREGATE
. Forcing that into the loop causes aKeyError
if it wasn't already there. If it was already there, then adding it again isn't needed.This also brings
_generate_json
in line with what_generate_text
loops through.