Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP skip-initial-eor work #332

Closed
wants to merge 1 commit into from
Closed

WIP skip-initial-eor work #332

wants to merge 1 commit into from

Conversation

charlescng
Copy link
Contributor

WIP

Review on Reviewable

@charlescng
Copy link
Contributor Author

Oops, wrong repo

@charlescng charlescng closed this Sep 16, 2015
@thomas-mangin
Copy link
Member

Very good work. I would suggest a few things:

  • rename 'skip-initial-eor' to 'manual-eor' (or 'manually-send-eor' ?)
  • make it an option with 'never', 'initial' and 'always' ( if you have better idea for the names feel free to come with options 😉 )
  • change the code in the main loop to send it if not set to always
  • make sure the Neighbor class when printed does include the option
  • add the right .group and .sequence file for your configuration file (will require an helper script for this)

Fantastic work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants