chore: cleanups + use css + setup pre-commit hook #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mat3ra-materials-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timurbazhirov
changed the title
VsevolodX
approved these changes
Mar 27, 2024
.husky/pre-commit
Outdated
| echo ">>>>>>>> Husky Pre-commit: Adding transpiled sources in dist" | ||
| echo "" | ||
| git add dist | ||
| echo "" |
...mber/support/step_definitions/When I generate interpolated set with # intermediate images.js
Show resolved
Hide resolved
| "testsOnly": "bash run-tests.sh -s=true", | ||
| "transpile": "tsc && npm run copy-css", | ||
| "copy-css": "cp src/stylesheets/* dist/stylesheets/", | ||
| "test": "echo 'Tests are in the tests subfolder. Use Node 20 (`nvm use 20`) and run `npm i` && `npm test` there'", |
There was a problem hiding this comment.
Can we add a cd tests && nvm use 20 && npm i && npm test && cd - instead of a directive? Or is this too fragile?
There was a problem hiding this comment.
Good idea, but with nvm there's too much logic in this command. Let's wait until we are on Node 20 for both app and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.