-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOF-7354: show labels with atomic symbols when present #152
Merged
Merged
Changes from 3 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d738651
SOF-7354: show labels with atomic symbols when present
pranabdas 911c30d
SOF-7354: chore ==> remove unused import and lint fix
pranabdas 64533a3
SOF-7354: chore ==> bump github workflow actions
pranabdas 217fbae
SOF-7354: update atomName in tests
pranabdas 00792e8
SOF-7354: bump esse and made
pranabdas 00311f4
SOF-7354: update macos screenshot asset
pranabdas a507f56
SOF-7354: remove duplicate centos screenshots
pranabdas 7eaaadd
SOF-7354: set slightly different color for atoms with labels
pranabdas d165223
SOF-7354: add missing screenshot for ubuntu snapshot test
pranabdas 481cb88
SOF-7354: add snapshot test for colors of atoms with labels
pranabdas 7080394
SOF-7354: chore ==> fix linter error
pranabdas a9229f6
SOF-7354: fix screenshot filename
pranabdas f99fc5e
SOF-7354: remove obsolete docker-compose version line
pranabdas fe6be12
SOF-7354: chore ==> reference for THREE.Color.lerp
pranabdas 54c61e5
SOF-7354: update visually similar snapshots for ubuntu
pranabdas 519fa0b
SOF-7354: set glow to atoms with labels instead of changing colors
pranabdas d1e0b62
SOF-7354: set lower glow intensity
pranabdas 75e04b6
SOF-7354: try different glow intensity
pranabdas 9231964
SOF-7354: try different saturation and intensity
pranabdas f6caf64
SOF-7354: more experiment with colors
pranabdas 144e039
SOF-7354: more experiment with colors x2
pranabdas 173af7c
SOF-7354: more experiment with colors x3
pranabdas 46672f5
SOF-7354: more experiment with colors x4
pranabdas 1d15176
SOF-7354: fix object cloning by storing additional data in userData
pranabdas 9e33e3e
SOF-7354: store apply glow logic in separate function in utils
pranabdas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if we can add a tests as well