Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Commit

Permalink
(picker) makes unit tests async
Browse files Browse the repository at this point in the history
  • Loading branch information
Christopher McCulloh committed Sep 18, 2015
1 parent 5750758 commit 40daa50
Show file tree
Hide file tree
Showing 3 changed files with 119 additions and 34 deletions.
2 changes: 1 addition & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"devDependencies": {
"jquery": null,
"jquery-1.9.1": "jquery#1.9.1",
"qunit": "~1.14.0",
"qunit": "1.x",
"requirejs-text": "2.x",
"underscore": "1.x",
"blanket": "1.x"
Expand Down
5 changes: 3 additions & 2 deletions index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1249,11 +1249,12 @@ define(function (require) {
$('#mypicker').on('accepted.fu.picker', function() {
console.log('accepted.fu.picker');
});

$('#mypicker').on('cancelled.fu.picker', function() {
console.log('cancelled.fu.picker');
});

$('#mypicker').on('exited.fu.picker', function() {
console.log('exited.fu.picker');
});
$('#mypicker').on('shown.fu.picker', function() {
console.log('shown.fu.picker');
});
Expand Down
146 changes: 115 additions & 31 deletions test/picker-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,27 @@ define(function(require){
ok($picker.picker() === $picker, 'picker should be initialized');
});

test('should behave as expected - input', function(){
test('should show and hide as expected - input', function(assert){
var $picker = $(html).find('#picker1');

$('body').append($picker);
$picker.picker();
$picker.on('cancelled.fu.picker', function(e, helpers){
ok(1===1, 'default action event (cancel) triggered upon external click');
});

var cancelledDone = assert.async();
var allDone = assert.async();

var $textInputTrigger = $($picker.find('.picker-trigger')[0]);
var $otherTrigger = $($picker.find('.picker-trigger')[1]);
$textInputTrigger.focus().focus();
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');

$picker.one('exited.fu.picker', function(e, helpers){
ok(1===1, 'default action event (exited) triggered upon external click');
cancelledDone();
});

$('body').click();

equal($picker.hasClass('showing'), false, 'picker hides when appropriate');

$textInputTrigger.click();
Expand All @@ -47,117 +53,195 @@ define(function(require){
equal($picker.hasClass('showing'), false, 'picker hides when non-text input clicked and picker is already showing');

$picker.remove();
allDone();
});

test('should behave as expected - button', function(){
test('should behave as expected - button', function(assert){
var $picker = $(html).find('#picker2');

$('body').append($picker);
$picker.picker();
$picker.on('cancelled.fu.picker', function(e, helpers){
ok(1===1, 'default action event (cancel) triggered upon external click');

var cancelledDone = assert.async();
var allDone = assert.async();
$picker.one('exited.fu.picker', function(e, helpers){
ok(1===1, 'default action event (exited) triggered upon external click');
cancelledDone();
});
$('body').append($picker);

$($picker.find('.picker-trigger')[1]).click();
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');

$('body').click();
equal($picker.hasClass('showing'), false, 'picker hides when appropriate');
$picker.remove();

allDone();
});

test('show/hide functions should behave as expected', function(){
test('show/hide functions should behave as expected', function(assert){
var $picker = $(html).find('#picker1');
$('body').append($picker);
$picker.picker();

$picker.on('shown.fu.picker', function(e, helpers){
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');
});
var shownDone = assert.async();
var hiddenDone = assert.async();
var allDone = assert.async();

$picker.on('hidden.fu.picker', function(e, helpers){
equal($picker.hasClass('showing'), false, 'picker shows when appropriate');
$picker.one('shown.fu.picker', function(e){
ok(1===1, 'shown event triggers on show');
equal(typeof e, 'object', 'event object passed in shown event');
shownDone();
});
$picker.one('hidden.fu.picker', function(e, helpers){
ok(1===1, 'hidden event triggers on hide');
equal(typeof e, 'object', 'event object passed in hidden event');
hiddenDone();
});

$picker.picker('show');
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');

$picker.picker('hide');
equal($picker.hasClass('showing'), false, 'picker hides when appropriate');

allDone();

$picker.remove();
});

test('trigger events should fire as expected', function(){
test('trigger events should fire as expected', function(assert){
var $picker = $(html).find('#picker1');

$('body').append($picker);
$picker.picker();
$picker.on('accepted.fu.picker', function(e, helpers){


var acceptedDone = assert.async();
var cancelledDone = assert.async();
var exitedDone = assert.async();
var allDone = assert.async();

$picker.one('accepted.fu.picker', function(e, helpers){
ok(1===1, 'accept event triggers on accept');
equal(typeof e, 'object', 'event object passed in accept event');
equal(typeof helpers, 'object', 'helpers object passed in accept event');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
acceptedDone();
});
$picker.on('cancelled.fu.picker', function(e, helpers){
$picker.one('cancelled.fu.picker', function(e, helpers){
ok(1===1, 'cancel event triggers on cancel');
equal(typeof e, 'object', 'event object passed in cancel event');
equal(typeof helpers, 'object', 'helpers object passed in cancel event');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
cancelledDone();
});
$picker.on('exited.fu.picker', function(e, helpers){
ok(1===1, 'exit event triggers on exit');
equal(typeof e, 'object', 'event object passed in exit event');
equal(typeof helpers, 'object', 'helpers object passed in exit event');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
exitedDone();
});

$picker.find('input').focus().focus();

$picker.find('.picker-trigger')[0].click();
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');
$picker.find('.picker-cancel').click();
$picker.find('input').focus().focus();
equal($picker.hasClass('showing'), false, 'picker hides when appropriate');
$picker.find('.picker-trigger')[0].click();
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');
$picker.find('.picker-accept').click();
equal($picker.hasClass('showing'), false, 'picker hides when appropriate');
$picker.find('.picker-trigger')[0].click();
equal($picker.hasClass('showing'), true, 'picker shows when appropriate');
$('body').click();
equal($picker.hasClass('showing'), false, 'picker hides when appropriate');
allDone();

$picker.remove();
});

test('onAccept function should be called as expected', function(){
test('onAccept function should be called as expected', function(assert){
var $picker = $(html).find('#picker1');

var acceptedDone = assert.async();
$picker.picker({
onAccept: function(helpers){
ok(1===1, 'onAccept function called on accept');
equal(typeof helpers, 'object', 'helpers object passed to onAccept function');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
$picker.picker('hide');
acceptedDone();
}
});

$picker.find('input').focus().focus();
$picker.find('.picker-trigger')[0].click();
$picker.find('.picker-accept').click();
});

test('onCancel function should be called as expected', function(){
test('onCancel function should be called as expected', function(assert){
var $picker = $(html).find('#picker1');

var cancelledDone = assert.async();
$picker.picker({
onCancel: function(helpers){
ok(1===1, 'onCancel function called on cancel');
equal(typeof helpers, 'object', 'helpers object passed to onCancel function');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
$picker.picker('hide');
cancelledDone();
}
});

$picker.find('input').focus().focus();
$picker.find('.picker-trigger')[0].click();
$picker.find('.picker-cancel').click();
});

test('Enter and exit keys should trigger appropriate response', function(){
test('onExit function should be called as expected', function(assert){
var $picker = $(html).find('#picker1');
$('body').append($picker);

var exitedDone = assert.async();
$picker.picker({
onExit: function(helpers){
ok(1===1, 'onExit function called on exit');
equal(typeof helpers, 'object', 'helpers object passed to onExit function');
equal((helpers.contents!==undefined), true, 'helpers object contains correct attributes');
$picker.picker('hide');
exitedDone();
}
});

$picker.find('.picker-trigger')[0].click();
$('body').click();
});

test('Enter and exit keys should trigger appropriate response', function(assert){
var $picker = $(html).find('#picker1');
var $input = $picker.find('input');
$('body').append($picker);

var $input = $($picker.find('input')[0]);
var e = $.Event("keydown");

var acceptedDone = assert.async();
var exitedDone = assert.async();
$picker.picker({
onAccept: function(){
onAccept: function(e){
ok(1===1, 'onAccept function called when enter keypress');
acceptedDone();
},
onCancel: function(){
ok(1===1, 'onCancel function called when exit keypress');
onExit: function(){
ok(1===1, 'onExit function called when exit keypress');
exitedDone();
}
});

e.keyCode = 13;
$input.trigger(e);
e.keyCode = 27;
$input.trigger(e);

$picker.remove();
});


Expand All @@ -170,7 +254,7 @@ define(function(require){
externalClickExceptions: ['.test', '#test']
});

$picker.find('input').focus().focus();
$picker.find('.picker-trigger')[0].click();
$('#test').click();
equal($picker.hasClass('showing'), true, 'externalClick ignored for specified id');
$('.test').click();
Expand All @@ -190,7 +274,7 @@ define(function(require){
explicit: true
});

$picker.find('input').focus().focus();
$picker.find('.picker-trigger')[0].click();
$('body').click();
equal($picker.hasClass('showing'), true, 'externalClick ignored due to not being an explicit accept/cancel action');
$picker.find('.picker-accept').click();
Expand Down

0 comments on commit 40daa50

Please sign in to comment.