Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amrex and amrex-hydro submodules #1106

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Jun 20, 2024

Summary

Update amrex and amrex-hydro submodules. Waiting on

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Got 1e-14 diffs on CPU for abl_bndry_output_amr_native and abl_bndry_output_amr_inflow. Assuming that's fine.

Additional background

Closes: #886
Closes: #1102

@marchdf marchdf requested a review from jrood-nrel June 21, 2024 18:50
@marchdf marchdf marked this pull request as ready for review June 21, 2024 19:46
@marchdf marchdf enabled auto-merge (squash) June 21, 2024 19:46
@marchdf marchdf merged commit de0f7c6 into Exawind:main Jun 24, 2024
13 checks passed
@marchdf marchdf deleted the update-submods branch June 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAC projection maxing out on ABL calculations
2 participants