Bottom Solver: Keep the unconverged result if it's an improvement #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalmgren
approved these changes
Jun 19, 2024
This was referenced Jun 20, 2024
|
Running regression tests now. Once it passes, I will merge it. |
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 4, 2024
This is a follow-up on AMReX-Codes#3991. For BottomSolver::bicgcg, it is supposed to switch to cg if bicg fails. Note that this does not revert AMReX-Codes#3991 completely. It fixes the implementation in AMReX-Codes#3991. We still keep the unconverged result if it's an improvement.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 4, 2024
This is a follow-up on AMReX-Codes#3991. For BottomSolver::bicgcg, it is supposed to switch to cg if bicg fails. Note that this does not revert AMReX-Codes#3991 completely. It fixes the implementation in AMReX-Codes#3991. We still keep the unconverged result if it's an improvement.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 4, 2024
This is a follow-up on AMReX-Codes#3991. For BottomSolver::bicgcg, it is supposed to switch to cg if bicg fails. Note that this does not revert AMReX-Codes#3991 completely. It fixes the implementation in AMReX-Codes#3991. We still keep the unconverged result if it's an improvement.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Jul 4, 2024
This is a follow-up on AMReX-Codes#3991. For BottomSolver::bicgcg, it is supposed to switch to cg if bicg fails. Note that this does not revert AMReX-Codes#3991 completely. It fixes the implementation in AMReX-Codes#3991. We still keep the unconverged result if it's an improvement.
WeiqunZhang
added a commit
that referenced
this pull request
Jul 5, 2024
This is a follow-up on #3991. For BottomSolver::bicgcg, it is supposed to switch to cg if bicg fails. Note that this does not revert #3991 completely. It fixes the implementation in #3991. We still keep the unconverged result if it's an improvement. X-Ref: AMReX-Combustion/PeleLMeX#396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.