Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding http to server to serve saved CEX orders #133

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rsercano
Copy link

@rsercano rsercano commented Jan 9, 2021

Hi @erkarl,

This's a draft PR to add http functionality into arby as per #85. But in general I'm having problems with rxjs and http. And I'm taking my words back that I said "it's not a big deal to add http after save". It's the biggest deal holy ...

Issues:

  • This starts the server but I never get what I wanted from http://localhost:10000/orders, when I do a GET it stucks, even I defined routes in the pipe.
  • This never closes the server/db. I also have a problem there.

This branch is over #125. So either you can check this after we merge #125 or you can check both, and your help would be appreciated srsly.

Thanks!

@rsercano rsercano requested a review from erkarl January 9, 2021 11:21
@rsercano rsercano marked this pull request as draft January 9, 2021 11:22
@rsercano rsercano changed the title Adding http to server saved CEX orders Adding http to server to serve saved CEX orders Jan 9, 2021
@rsercano rsercano self-assigned this Jan 9, 2021
@ExchangeUnion ExchangeUnion deleted a comment from cemuney Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant