Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure needed assets #140

Open
peartobear opened this issue Aug 29, 2019 · 9 comments
Open

Configure needed assets #140

peartobear opened this issue Aug 29, 2019 · 9 comments
Assignees
Labels
P1 top priority user request Requested by end-user

Comments

@peartobear
Copy link

Configuring docker to allow for easily customizable asset choice by picking and choosing nodes and chains to sync would not only save lot of syncing time for people running full nodes but would also allow for a more abstract interface for apps building on top of the deamon. For instance, someone not planning to trade LTC would choose to not sync the litecoin node.

@peartobear peartobear changed the title Feature request: Configure the assets that is only needed. Feature request: Configure assets that is only needed. Aug 29, 2019
@peartobear peartobear changed the title Feature request: Configure assets that is only needed. Feature request: configuring needed assets Aug 29, 2019
@kilrau
Copy link
Contributor

kilrau commented Sep 2, 2019

Part of #30

@kilrau kilrau mentioned this issue Sep 5, 2019
6 tasks
@kilrau kilrau added enhancement New feature or request P2 mid priority labels Oct 8, 2019
@kilrau
Copy link
Contributor

kilrau commented Oct 30, 2019

Which assets do you plan to trade? Multiple choices separated by comma.
1. BTC
2. LTC
3. ERC20(ETH)
4. ALL
Please choose: 1,3
You selected BTC, ETH-ERC20. Is that correct? [Y/n]

@kilrau kilrau changed the title Feature request: configuring needed assets Configure needed assets Oct 30, 2019
@kilrau
Copy link
Contributor

kilrau commented Dec 9, 2019

Also moving this one to the next project.

@kilrau
Copy link
Contributor

kilrau commented Jan 14, 2020

Persisted in $NETWORK.conf as boolean for each asset .Default is ALL, user is only asked once, if script is exited or any other sort of error occurs, default (all 1) is set and script continues.

@raladev
Copy link
Contributor

raladev commented Jul 16, 2020

one more suggestion:
We can use cmd params approach that we use with optional containers:

  --arby.disabled [ARBY.DISABLED]
  --boltz.disabled [BOLTZ.DISABLED]
  --webui.disabled [WEBUI.DISABLED]

--lndltc.enbaled false (true as default)
--lndbtc.enbaled false (true as default)
--connext.enbaled false (true as default)

@ghost
Copy link

ghost commented Sep 2, 2020

Bumping this issue as it's annoying to run litecoind and lnd-ltc when I have no interest in using them.

@kilrau kilrau added the user request Requested by end-user label Sep 2, 2020
@kilrau kilrau added P1 top priority and removed P2 mid priority enhancement New feature or request labels Oct 19, 2020
@kilrau
Copy link
Contributor

kilrau commented Oct 19, 2020

one more suggestion:
We can use cmd params approach that we use with optional containers:

  --arby.disabled [ARBY.DISABLED]
  --boltz.disabled [BOLTZ.DISABLED]
  --webui.disabled [WEBUI.DISABLED]

--lndltc.enbaled false (true as default)
--lndbtc.enbaled false (true as default)
--connext.enbaled false (true as default)

Actually thinking about this again - this might not be the best option since cli paramters are supposed to be temporary, whereas the selection here is more permanent. I think #140 (comment) is the better way for now.

@kilrau
Copy link
Contributor

kilrau commented Oct 27, 2020

The xud dependency to initialize swap client at a later point in time finally has a PR: ExchangeUnion/xud#1961

This allows us to do the following in the course of this issue (best to split into several PRs):

  1. cli parameter + conf choice of assets:
--lndltc.enbaled false (true as default)
--lndbtc.enbaled false (true as default)
--connext.enbaled false (true as default)
  1. interactive choice of assets in create:
Which assets do you plan to trade? Multiple choices separated by comma.
1. BTC
2. LTC
3. ERC20(ETH)
4. ALL
Please choose: 1,3
You selected BTC, ETH-ERC20. Is that correct? [Y/n]
  1. Add asset any time during runtime:
    addcurrency should detect that currency (e.g. LTC) is supported, pull lndltc container, start it and initialize via feat(rpc): InitSwapClient xud#1961

@kilrau
Copy link
Contributor

kilrau commented Nov 6, 2020

We need this feature for Raspiblitz to start the environment with --lndltc.enbaled false there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 top priority user request Requested by end-user
Projects
None yet
Development

No branches or pull requests

4 participants