Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connext: open/closechannel calls #1472

Closed
kilrau opened this issue Apr 10, 2020 · 0 comments · Fixed by #1577
Closed

Connext: open/closechannel calls #1472

kilrau opened this issue Apr 10, 2020 · 0 comments · Fixed by #1577
Assignees
@sangaman
Labels
command line (CLI) Relating to the command line interface tools grpc gRPC API P1 top priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 10, 2020 •
edited
Loading

Equivalent of #1044 / #1471
@kilrau kilrau added grpc gRPC API P2 mid priority command line (CLI) Relating to the command line interface tools labels Apr 10, 2020
@kilrau kilrau changed the title Connext: Open/closechannel Connext: pen/closechannel calls Apr 10, 2020
@kilrau kilrau changed the title Connext: pen/closechannel calls Connext: open/closechannel calls Apr 13, 2020
sangaman added a commit that referenced this issue Apr 14, 2020
@sangaman
feat(rpc): CloseChannel call
49fc80e 
This introduces the ability to close channels through xud. Currently
this is only implemented for lnd, and is implemented in a naive way
that relies on the peer we are trying to close channels with being
online and cooperative.

Closes #1471. Follow-ups are #1472 and #1476.
@sangaman sangaman mentioned this issue Apr 14, 2020
Merged
sangaman added a commit that referenced this issue Apr 14, 2020
@sangaman
feat(rpc): CloseChannel call
fe6bba8 
This introduces the ability to close channels through xud. Currently
this is only implemented for lnd, and is implemented in a naive way
that relies on the peer we are trying to close channels with being
online and cooperative.

Closes #1471. Follow-ups are #1472 and #1476.
sangaman added a commit that referenced this issue Apr 14, 2020
@sangaman
feat(rpc): CloseChannel call
380cb26 
This introduces the ability to close channels through xud. Currently
this is only implemented for lnd, and is implemented in a naive way
that relies on the peer we are trying to close channels with being
online and cooperative.

Closes #1471. Follow-ups are #1472 and #1476.
sangaman added a commit that referenced this issue Apr 29, 2020
@sangaman
feat(rpc): CloseChannel call
f69fa7c 
This introduces the ability to close channels through xud. Currently
this is only implemented for lnd, and is implemented in a naive way
that relies on the peer we are trying to close channels with being
online and cooperative.

Closes #1471. Follow-ups are #1472 and #1476.
@kilrau kilrau added P1 top priority and removed P2 mid priority labels May 5, 2020
@kilrau kilrau mentioned this issue May 14, 2020
Closed
sangaman added a commit that referenced this issue May 25, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
edad1a8 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
@sangaman sangaman mentioned this issue May 25, 2020
Merged
sangaman added a commit that referenced this issue May 27, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
9d360b5 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
sangaman added a commit that referenced this issue May 29, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
800b4fb 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
sangaman added a commit that referenced this issue May 30, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
173cb90 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
sangaman added a commit that referenced this issue May 30, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
d85cf87 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
sangaman added a commit that referenced this issue May 30, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
6c33478 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
sangaman added a commit that referenced this issue Jun 3, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls
cdc8259 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
@ghost ghost closed this as completed in #1577 Jun 5, 2020
ghost pushed a commit that referenced this issue Jun 5, 2020
@sangaman
feat(rpc/connext): deposit & openchannel calls (#1577)
ebb715e 
This refactors the `Deposit` and `OpenChannel` methods in `SwapClient`
to make them generic and applicable to Connext. It implements this
functionality for Connext, namely retrieiving an address for sending
funds on-chain to the Connext wallet and depositing those funds into
Connext channels.

It also refactors the `CloseChannel` call similarly, however the
Connext REST client does not currently implement a `/withdraw` endpoint
for taking funds out of Connext channels. This adds dummy code to
construct a withdraw payload and make a request.

Withdrawing coins from the on-chain Connext wallet is not currently
supported by the Connext client and so the `Withdraw` rpc call remains
specific to lnd.

Closes #1472. Closes #1473.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
command line (CLI) Relating to the command line interface tools grpc gRPC API P1 top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rpc/connext): deposit & openchannel calls ExchangeUnion/xud
2 participants
@sangaman @kilrau