Unify map extraction: use --padding option (and default value) in QFitSegment #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-riley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
devbranch?Exceptions will be made for urgent bugfixes.
dev?If not, please rebase your PR onto the most recent
devtip.Explain to a new user by completing the sentence: 'This PR will: ...'
Description of the Change
QFitSegment was using a custom 'padding' during map extraction.
This commit changes the map extraction in QFitSegment to use the same routine as is being used in QFitRotamericResidue (and elsewhere).
We currently ask the user what padding they'd like for map calculations: we should respect that.
Release Notes