Split QP step into two in sample sidechain #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If too many conformers are generated during sidechain, split conformer array into two sections and score them separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If too many conformers are generated during sidechain, split conformer array into two sections and score them separately
Pull Request Checklist
devbranch?Exceptions will be made for urgent bugfixes.
dev?If not, please rebase your PR onto the most recent
devtip.Explain to a new user by completing the sentence: 'This PR will: ...'
Description of the Change
If too many conformers are generated during sample_sidechain(), split conformer array into two sections and score them separately. Concatenate after scoring both sections. This allows us to sample >15000 conformers without overloading QP.
This is a temporary fix. Ideally, we want to reduce sampling as the time sampling is getting increasingly high for these residues. However, we believe we can do that more effectively with attention based sampling and so are leaving this patch in here for now.
Release Notes
Split QP during sample_sidechain() in qfit.py