Add listen event and exec arguments #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoNardi
force-pushed
the
probe_links
branch
from
20cac1c
to
45e373c
Compare
MatteoNardi
force-pushed
the
new_probes
branch
from
c39136b
to
c4f88bb
Compare
banditopazzo
requested changes
Oct 6, 2022
Remove the unneeded unroll directive. Replace non-CORE probe_read calls, with CORE enabled ones.
banditopazzo
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #65 and #66
I'm not particularly happy about the performance implications of the arguments modification.
We're copying much data on every event to userspace, even if the arguments are smaller.
We should optimize these by using some variable size data structure.
We're cloning the arguments when getting info from process tracker https://github.com/Exein-io/pulsar/blob/c39136b3ad8862cb1882833fec2d78bbba958df7/pulsar-core/src/pdk/process_tracker.rs#L269
Even when most of the times we'll discard them: https://github.com/Exein-io/pulsar/blob/c39136b3ad8862cb1882833fec2d78bbba958df7/pulsar-core/src/pdk/module.rs#L184-L191
We could (A) add a different method, complicating the API or (B) use an Arc. What do you think?
I have
cargo fmt;cargo clippy;cargo testand all tests pass;