Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PSR-4 autoloading. #29

Merged
merged 1 commit into from
Aug 28, 2015
Merged

use PSR-4 autoloading. #29

merged 1 commit into from
Aug 28, 2015

Conversation

bangpound
Copy link
Contributor

This flattens out the directory structure in vendor (and closes out all my reasons for forking this bundle).

@tgabi333
Copy link

+1

@spolischook
Copy link
Contributor

+2, why you need this? what that broken?

@bangpound
Copy link
Contributor Author

It flattens the directory structure and makes it much easier to navigate my vendor directory and make patches that I can contribute upstream. It's a small thing, but it makes a difference to how easy is it would be to contribute to this project.

@spolischook
Copy link
Contributor

nice, is it broke some backward compatibility? especially interested Symfony 2.3

@bangpound
Copy link
Contributor Author

I do not believe that this will not break backward compatability with Symfony. Instead, it simply requires a newer version of Composer to support PSR-4 autoloading. Composer has supported PSR-4 since January 2014 and there have been 2 or 3 alpha releases since this feature was added.

@stof
Copy link
Contributor

stof commented Aug 28, 2015

@spolischook no BC break at all, as Symfony does not hardcode anything related to bundle locations since 2.1+. It relies on autoloading to find their location.

👍 for this as the target-dir setting in Composer is considered legacy (it was implemented because we were missing PSR-4 at that time, to cover 1 subcase of PSR-4)

spolischook added a commit that referenced this pull request Aug 28, 2015
@spolischook spolischook merged commit b158c87 into Exercise:master Aug 28, 2015
@spolischook
Copy link
Contributor

@bangpound bangpound deleted the feature/psr-4 branch August 28, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants