Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exiled.Events] Added PlacingPickupIntoPocketDimension event. #2256

Merged
merged 9 commits into from
Feb 3, 2024

Conversation

SnivyFilms
Copy link
Contributor

@SnivyFilms SnivyFilms commented Nov 14, 2023

Pickups have different behaviors in 106's pocket dimension. They have flags that determine if they have a 50%, 30%, or 0% chance of being deleted, playing sounds when a pickup does leave the pocket dimension, and determines where it will be ejected back into the rest of the facility.

I have no idea how to make a transpiler for this, but my hope is that this makes a solid start.

@Misaka-ZeroTwo Misaka-ZeroTwo added help wanted Extra attention is needed Do not merge Don't merge this PR labels Nov 15, 2023
@louis1706
Copy link
Member

i will see what i can do there

@louis1706 louis1706 marked this pull request as draft November 15, 2023 09:26
@NaoUnderscore NaoUnderscore added enhancement New feature or request regarding-events P2 Medium priority and removed help wanted Extra attention is needed Do not merge Don't merge this PR labels Feb 3, 2024
@NaoUnderscore NaoUnderscore added this to the Exiled 9 milestone Feb 3, 2024
@NaoUnderscore NaoUnderscore marked this pull request as ready for review February 3, 2024 19:16
@NaoUnderscore NaoUnderscore changed the title Added 106 Pocket Dimension pickup handler [Exiled.Events] Added PlacingPickupIntoPocketDimension event. Feb 3, 2024
@NaoUnderscore NaoUnderscore changed the base branch from dev to apis-rework February 3, 2024 21:45
@NaoUnderscore NaoUnderscore merged commit 0348dbb into Exiled-Team:apis-rework Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Medium priority regarding-events
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants