Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2.org problems due to the 0.28.0 release #2605

Open
postscript-dev opened this issue May 8, 2023 · 14 comments
Open

exiv2.org problems due to the 0.28.0 release #2605

postscript-dev opened this issue May 8, 2023 · 14 comments
Labels

Comments

@postscript-dev
Copy link
Collaborator

postscript-dev commented May 8, 2023

There are some minor fixes needed on https://exiv2.org after the 0.28.0 release.

Describe the bug

  1. The manpage on https://exiv2.org/manpage.html is invalid. The PDF link displays https://github.com/Exiv2/exiv2/blob/0.28.x/man/man1/exiv2.1 instead of https://github.com/Exiv2/exiv2/blob/0.28.x/exiv2.md .
  2. Missing 0.28.0 source download in https://exiv2.org/archive.html
  3. In https://exiv2.org/download.html , the "Download Source" file is missing.
  4. In https://exiv2.org/doc/examples.html , the exiv2json.cpp link doesn't work as the sample file was removed from the main branch.
  5. The 0.28.0 changelog is missing from https://exiv2.org/changelog.html .
  6. In https://exiv2.org/metadata.html , the tags are not listed in the various links (e.g. https://exiv2.org/tags-xmp-dc.html).

I haven't checked every link so it is possible that other problems may exist.

Additional context

There is a comment about the manpage that may be helpful (@nehaljwani )

When creating a significant release it is likely that small things will crop up. Hopefully these are simple to fix.

@nehaljwani
Copy link
Collaborator

Missing 0.28.0 source download in https://exiv2.org/archive.html

The archive page is for old releases only.

@nehaljwani
Copy link
Collaborator

nehaljwani commented May 9, 2023

In https://exiv2.org/download.html , the "Download Source" file is missing.

Fixed via Exiv2/team@82dbf8d

In https://exiv2.org/doc/examples.html , the exiv2json.cpp link doesn't work as the sample file was removed from the main branch.

Removed via Exiv2/team@31c9370

@postscript-dev
Copy link
Collaborator Author

postscript-dev commented May 9, 2023

@nehaljwani

Missing 0.28.0 source download in
https://exiv2.org/archive.html

The archive page is for old releases only

Yes, you're right. Thanks for checking

@postscript-dev
Copy link
Collaborator Author

@nehaljwani
I have just noticed one more thing. In https://exiv2.org/metadata.html , the tags are not listed in the various links (e.g. https://exiv2.org/tags-xmp-dc.html).

@nehaljwani
Copy link
Collaborator

The manpage on https://exiv2.org/manpage.html is invalid. The PDF link displays https://github.com/Exiv2/exiv2/blob/0.28.x/man/man1/exiv2.1 instead of https://github.com/Exiv2/exiv2/blob/0.28.x/exiv2.md .

Fixed via Exiv2/team@f496fc1 & Exiv2/team@4ba5e6f

@nehaljwani
Copy link
Collaborator

In https://exiv2.org/metadata.html , the tags are not listed in the various links

Fixed via Exiv2/team@b09d596

@clanmills
Copy link
Collaborator

Great Work, Everybody - especially @nehaljwani and @postscript-dev

I built 0.28 this morning on macOS. cmake cannot find Findinih.cmake

-- Could NOT find inih (missing: inih_LIBRARY inih_INCLUDE_DIR) 
CMake Error at cmake/Findinih.cmake:28 (message):
  inih library not found
Call Stack (most recent call first):
  cmake/findDependencies.cmake:80 (find_package)
  CMakeLists.txt:86 (include)

I successfully build with these commands:

$ cmake .. -DEXIV2_ENABLE_INIH=0 -DEXIV2_ENABLE_WEBREADY=1 -DEXIV2_ENABLE_CURL=1 
$ make
$ 

Can you remove my name and email address from the .MD files on 'main'. These files may be a little "stale" and I'm no longer in a position to answer questions from users.

808 rmills@rmillsm1:~/gnu/github/exiv2/main/b $ grep robin ../*.md
../README-CONAN.md:Written by Robin Mills<br>robin@clanmills.com<br>Updated: 2021-12-17
../README-SAMPLES.md:robin@clanmills.com<br>
../README.md:Written by Robin Mills<br>robin@clanmills.com<br>Updated: 2022-02-22
809 rmills@rmillsm1:~/gnu/github/exiv2/main/b $ 

@nehaljwani
Copy link
Collaborator

The 0.28.0 changelog is missing from https://exiv2.org/changelog.html .

Fixed via Exiv2/team@0a7b0ac

@luzpaz
Copy link
Contributor

luzpaz commented Jul 25, 2023

What's left here ?

@kmilos
Copy link
Collaborator

kmilos commented Nov 7, 2023

@nehaljwani @kevinbackhouse I guess all of this needs updating again after yesterday's 0.28.1 release? See also #2821

@eclipseo
Copy link

could we also have the list of breaking change from 0.28.0?

@kevinbackhouse
Copy link
Collaborator

@nehaljwani @kevinbackhouse I guess all of this needs updating again after yesterday's 0.28.1 release? See also #2821

I've made an attempt at it here: Exiv2/team#4

I see that the repo has a workflow file, so I'm hoping that the website will get updated automatically.

@kevinbackhouse
Copy link
Collaborator

could we also have the list of breaking change from 0.28.0?

None as far I know. All the backwards-incompatible changes happened between 0.27 and 0.28.

@eclipseo
Copy link

could we also have the list of breaking change from 0.28.0?

None as far I know. All the backwards-incompatible changes happened between 0.27 and 0.28.

yes that what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants