Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source release archive for 0.28.1 and 0.28.2 #2821

Open
diizzyy opened this issue Nov 7, 2023 · 8 comments
Open

Missing source release archive for 0.28.1 and 0.28.2 #2821

diizzyy opened this issue Nov 7, 2023 · 8 comments
Labels

Comments

@diizzyy
Copy link

diizzyy commented Nov 7, 2023

Please generate one as it could help packaging a lot and also because of https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/

@diizzyy
Copy link
Author

diizzyy commented Feb 15, 2024

@kevinbackhouse
Is it possible to have one uploaded to GitHub, especially due to https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/ ?

@diizzyy diizzyy changed the title Missing source release archive for 0.28.1 Missing source release archive for 0.28.1 and 0.28.2 Feb 15, 2024
@kevinbackhouse
Copy link
Collaborator

@kmilos
Copy link
Collaborator

kmilos commented Feb 19, 2024

Aren't these what you're looking for?

I think what he's saying is that one shouldn't rely on GitHub auto-generated tarballs as they can change, so any verification by hash is difficult/pointless long term...

@diizzyy
Copy link
Author

diizzyy commented Feb 19, 2024

@kmilos
Indeed, it makes packaging troublesome

@kevinbackhouse
Copy link
Collaborator

@diizzyy: I don't understand what you want me to do. Please could you give me very precise instructions? Then I will consider it.

@kmilos
Copy link
Collaborator

kmilos commented Feb 20, 2024

@kevinbackhouse @nehaljwani The request is for a manually generated source tarball that is then manually added to release assets, like it was done for all releases up to 0.28.0: https://github.com/Exiv2/exiv2/releases/tag/v0.28.0

See

exiv2/README.md

Line 564 in 8414a98

$ cmake --build build --target package_source

@kevinbackhouse
Copy link
Collaborator

I still don't understand what problem this would solve. If somebody is particularly concerned about verifying the authenticity of the code, surely they should get it from the git repository directly, rather than relying on a tarball that was uploaded manually? I put gpg-signed tags on v0.28.1 and v0.28.2 for that purpose. You can also download a tarball for an arbitrary commit like this: https://github.com/Exiv2/exiv2/archive/04207b9c39bf7b3b1a7144f7ed4e4f16b4f29ef6.zip

@kmilos
Copy link
Collaborator

kmilos commented Feb 20, 2024

I still don't understand what problem this would solve.

As linked above, the GitHub auto-generated source tarballs are not permanent (only cached for a year), so their hash can change.

Most distros use the tarball + hash in their packaging scripts so this is not a permanent solution. (One can argue that's not a good approach anyway, but that's besides the point here - there are way to many of them to force them to change straight away.)

https://gitlab.archlinux.org/archlinux/packaging/packages/exiv2/-/blob/main/.SRCINFO?ref_type=heads
https://src.fedoraproject.org/rpms/exiv2/blob/rawhide/f/sources
https://gitweb.gentoo.org/repo/gentoo.git/tree/media-gfx/exiv2/Manifest
https://github.com/macports/macports-ports/blob/master/graphics/exiv2/Portfile

etc. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants