Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv 0.28: test failure with brotli 1.1 #2802

Closed
jengelh opened this issue Oct 20, 2023 · 1 comment
Closed

exiv 0.28: test failure with brotli 1.1 #2802

jengelh opened this issue Oct 20, 2023 · 1 comment

Comments

@jengelh
Copy link

jengelh commented Oct 20, 2023

Describe the bug

brotli 1.1 (more specifically commit ) changed its output and now the exiv2 testsuite falls over because it relied on seeing a particular string.

commit 2e6164d7b0b7bdcb5d731bee6dd0f4e06708e006
Author: Evgenii Kliuchnikov <eustas@google.com>
Date:   Mon Jul 10 11:40:07 2023 +0000

    verbose error report in CLI
    
    PiperOrigin-RevId: 546833411

 c/dec/decode.c   |  2 +-
 c/tools/brotli.c | 29 ++++++++++++++++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

To Reproduce

Steps to reproduce the behavior:

  1. Install brotli-1.1, run the exiv2-0.28 (release tarball) testsuite.
  2. Observe failure
[  139s] ======================================================================
[  139s] FAIL: test_run (github.test_issue_2427.issue_2427_BmffImage_brotliUncompress_memleak.test_run)
[  139s] ----------------------------------------------------------------------
[  139s] Traceback (most recent call last):
[  139s]   File "/home/abuild/rpmbuild/BUILD/exiv2-0.28.0/tests/system_tests.py", line 652, in test_run
[  139s]     self.compare_stderr(i, command, processed_stderr, stderr)
[  139s]   File "/home/abuild/rpmbuild/BUILD/exiv2-0.28.0/tests/system_tests.py", line 773, in compare_stderr
[  139s]     self._compare_output(
[  139s]   File "/home/abuild/rpmbuild/BUILD/exiv2-0.28.0/tests/system_tests.py", line 745, in _compare_output
[  139s]     self.assertMultiLineEqual(
[  139s] AssertionError: 'Exiv[71 chars]0.28.0/test/data/issue_2427_poc.jpg:\n_ERROR_FORMAT_CL_SPACE\n' != 'Exiv[71 chars]0.28.0/test/data/issue_2427_poc.jpg:\nCL_SPACE\n'
[  139s]   Exiv2 exception in print action for file /home/abuild/rpmbuild/BUILD/exiv2-0.28.0/test/data/issue_2427_poc.jpg:
[  139s] - _ERROR_FORMAT_CL_SPACE
[  139s] + CL_SPACE
[  139s]  : Standard error does not match

Desktop (please complete the following information):

  • openSUSE Tumbleweed in staging
  • Exiv2 version [md5 0d8d2ab50eb73228f8d1ffa36561bf53] exiv2-0.28.0.tar.gz
  • Compiler and version: gcc version 13.2.1 20230912 [revision b96e66fd4ef3e36983969fb8cdd1956f551a074b] (SUSE Linux)
  • Compilation mode and/or compiler flags:
[    7s] + /usr/bin/cmake /home/abuild/rpmbuild/BUILD/exiv2-0.28.0/. '-GUnix Makefiles' -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_BINDIR:PATH=bin -DCMAKE_INSTALL_SBINDIR:PATH=sbin -DCMAKE_INSTALL_LIBEXECDIR:PATH=libexec -DCMAKE_INSTALL_SYSCONFDIR:PATH=etc -DCMAKE_INSTALL_SHAREDSTATEDIR:PATH=/var/lib -DCMAKE_INSTALL_LOCALSTATEDIR:PATH=var -DCMAKE_INSTALL_RUNSTATEDIR:PATH=run -DCMAKE_INSTALL_LIBDIR:PATH=lib64 -DCMAKE_INSTALL_INCLUDEDIR:PATH=include -DCMAKE_INSTALL_DATAROOTDIR:PATH=share -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_BUILD_TYPE=RelWithDebInfo '-DCMAKE_C_FLAGS=-march=x86-64-v3 -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -ffat-lto-objects -g ' '-DCMAKE_CXX_FLAGS=-march=x86-64-v3 -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -ffat-lto-objects -g ' '-DCMAKE_Fortran_FLAGS=-march=x86-64-v3 -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -ffat-lto-objects -g' '-DCMAKE_EXE_LINKER_FLAGS=-flto=auto -ffat-lto-objects -Wl,--as-needed -Wl,-z,now' '-DCMAKE_MODULE_LINKER_FLAGS=-flto=auto -ffat-lto-objects -Wl,--as-needed' '-DCMAKE_SHARED_LINKER_FLAGS=-flto=auto -ffat-lto-objects -Wl,--as-needed -Wl,-z,now' -DLIB_SUFFIX=64 -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF -DCMAKE_COLOR_MAKEFILE:BOOL=OFF -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_MODULES_INSTALL_DIR=/usr/lib64/cmake/exiv2 -DCMAKE_INSTALL_DOCDIR=/usr/share/doc/packages/libexiv2 -DEXIV2_BUILD_SAMPLES=ON -DEXIV2_BUILD_UNIT_TESTS=ON -DEXIV2_BUILD_PO=ON -DEXIV2_BUILD_DOC=OFF -DEXIV2_ENABLE_CURL=ON -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_NLS=ON -DEXIV2_ENABLE_BMFF=ON -DCMAKE_SKIP_RPATH=OFF
@jengelh jengelh added the bug label Oct 20, 2023
@kmilos
Copy link
Collaborator

kmilos commented Oct 20, 2023

Duplicate of #2762 and #2763

Please search before opening new issues.

@kmilos kmilos closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@kmilos kmilos added duplicate and removed bug labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants