Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix brotli test #2763

Closed
wants to merge 1 commit into from
Closed

try to fix brotli test #2763

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Sep 11, 2023

No description provided.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ghost
Copy link

ghost commented Sep 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb
Copy link
Collaborator Author

neheb commented Sep 11, 2023

ping @Biswa96

seems to be a regression in at least the UCRT package.

@Biswa96
Copy link

Biswa96 commented Sep 11, 2023

Which test are you asking about? Multiple tests failed here.

@neheb
Copy link
Collaborator Author

neheb commented Sep 11, 2023

Look at other recent PRs

@Biswa96
Copy link

Biswa96 commented Sep 11, 2023

This PR fixes the test in ucrt64. But I can not figure out who is wrong here - exiv2 or brotli. Does any CI job use brotli 1.1.0 ? @kmilos may provide some info.

@neheb
Copy link
Collaborator Author

neheb commented Sep 11, 2023

CL_SPACE should be the correct value. I don't know if this is an msys bug or upstream.

@kmilos
Copy link
Collaborator

kmilos commented Sep 11, 2023

Does any CI job use brotli 1.1.0 ?

It does for the UCRT64 job: https://github.com/Exiv2/exiv2/actions/runs/6140387211/job/16659286923#step:3:195

The Cygwin one is still on 1.0.9: https://github.com/Exiv2/exiv2/actions/runs/6140387211/job/16659286365#step:4:155

@kmilos
Copy link
Collaborator

kmilos commented Sep 11, 2023

Looks like this failed on Linux as well in #2762?

@neheb
Copy link
Collaborator Author

neheb commented Sep 11, 2023

So upstream bug.

@kmilos
Copy link
Collaborator

kmilos commented Sep 21, 2023

So upstream bug.

Pinged upstream, looks like this is expected behaviour now from 1.1.0...

So we need to either detect the brotli version, and/or check both return values 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants