Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens Recognition for Sigma 24mm f/1.4 DG HSM Art #2877

Closed
Macchiato17 opened this issue Jan 1, 2024 · 2 comments · Fixed by #2886
Closed

Lens Recognition for Sigma 24mm f/1.4 DG HSM Art #2877

Macchiato17 opened this issue Jan 1, 2024 · 2 comments · Fixed by #2886
Labels
lens Issue related to lens detection request feature request or any other kind of wish
Milestone

Comments

@Macchiato17
Copy link

Is your feature request related to a problem?

exiv2 doesn't recognize the lens Sigma 24mm f/1.4 DG HSM Art when used with a crop sensor, i.e. Nikon D7500.
I was reproducing that issue with darktable (built from current master) and also by directly launching exiv2 from a MINGW64 shell under Windows 11.

In the meantime, the crop related calibration data was added to the lensfun database (see lensfun issue 2126), the issue related to darktable not recognizing this lens and the content of the exiv2.ini is decribed in lensfun issue 2127.

Describe the solution you would like

Would be wonderful, if you may add recognition of this lens to exiv2.

Describe alternatives you have considered

As a work-around I created an exiv2.ini linking the lens ID with the lens name string found in the lensfun database

Desktop

  • Windows 11
  • Exiv2 version 0.27.7 installed via pacman
  • darktable built from current master

Additional context

I attached a JPEG file that was taken with this lens. Don't get confused, it's just a "black shot" 😉.
And I wish all of you developing, maintaining or otherwise contributing to this nice piece of software a Happy New Year 😃

@Macchiato17 Macchiato17 added the request feature request or any other kind of wish label Jan 1, 2024
@kmilos kmilos added the lens Issue related to lens detection label Jan 2, 2024
@kmilos
Copy link
Collaborator

kmilos commented Jan 8, 2024

Thanks for the sample.

@Macchiato17
Copy link
Author

Thanks for including the lens so quickly - have a good time.

@kmilos kmilos added this to the v0.28.2 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection request feature request or any other kind of wish
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants