Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sigma 24mm F1.4 DG HSM | A for Nikon #2886

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 8, 2024

Resolves #2877

@ghost
Copy link

ghost commented Jan 8, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos added the lens Issue related to lens detection label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (349c1f2) 63.89% compared to head (464c9b2) 63.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         103      103           
  Lines       22381    22381           
  Branches    10872    10872           
=======================================
  Hits        14301    14301           
  Misses       5857     5857           
  Partials     2223     2223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neheb neheb merged commit 52d4451 into main Jan 8, 2024
64 checks passed
@neheb neheb deleted the kmilos/sigma_24mm_nikon branch January 8, 2024 22:10
@kmilos
Copy link
Collaborator Author

kmilos commented Jan 12, 2024

@mergify backport 0.28.x

Copy link
Contributor

mergify bot commented Jan 12, 2024

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lens Recognition for Sigma 24mm f/1.4 DG HSM Art
2 participants