[0.26] Backport Nikon/Pentax metadata segfault #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical to commit:5405d61623e82896e498c5c8342dd6f42e689115
|
If there is an associated update of the test suite, could you please cherry-pick that one, too? |
piponazo
approved these changes
Nov 16, 2017
|
Thanks for catching that. Once #169 is merged into master, could you cherry pick that too? |
|
Sure, I'm subscribed there and waiting. |
http://dev.exiv2.org/issues/1305 (cherry picked from commit 305d221)
|
ping |
|
I have updated the bugfixes-test.out file and send you a patch via email. Unfortunately that binary monster is required to make the test suite pass (travis reports everything is fine because we have only fixed it on master and not in the 0.26 branch yet). Could you please apply the patch and push it, then I'll merge it. Sorry that it took so long. |
|
Thanks for applying the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this was missed so far.