Fix issues detected with PVS-Studio + other little improvements #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
- Coverage 66.90% 66.90% -0.01%
==========================================
Files 151 151
Lines 20781 20762 -19
==========================================
- Hits 13903 13890 -13
+ Misses 6878 6872 -6
Continue to review full report at Codecov.
|
|
Looks good. |
sridharb1
previously approved these changes
May 29, 2021
Most of the issues were identified via PVS-Studio and I wrote a suffix in the commit message. Although I might have forgotten to mark some of the commits with that prefix |
The width & height variables in the TiffImage class need to be mutable to be able to change their values on the getters pixelHeight() and pixelWidth() ... Do not ask me why ...
piponazo
force-pushed
the
main-SmallImprovements
branch
from
cb99031
to
b2daf20
Compare
kevinbackhouse
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am fixing several issues detected with PVS-Studio and few other issues detected while doing this work. Please review the changes commit per commit, since each one does something completely different.
https://pvs-studio.com/en
Note that I got a free PVS-Studio license for Exiv2 to my personal email account. I need to check if we can include this license to be used in CI and if other Exiv2 collaborators could use it or not. I will investigate that in the future 馃槈